-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App] Introduce Bi-directional queues #15582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Nov 8, 2022
tchaton
changed the title
Introduce Bi-directional queues
[App] Introduce Bi-directional queues
Nov 8, 2022
tchaton
requested review from
Borda,
carmocca and
akihironitta
as code owners
November 10, 2022 10:04
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Nov 10, 2022
Borda
pushed a commit
that referenced
this pull request
Nov 10, 2022
* update * update * update * update * update * udpate * update * update * update * update * update * updatre * update * update * update * updar * update * update * update * remove print * update * update * update * update * update * update * update * update (cherry picked from commit 10cdf0d)
lexierule
pushed a commit
that referenced
this pull request
Nov 10, 2022
* update * update * update * update * update * udpate * update * update * update * update * update * updatre * update * update * update * updar * update * update * update * remove print * update * update * update * update * update * update * update * update (cherry picked from commit 10cdf0d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
feature
Is an improvement or enhancement
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables bi-directional queues from the flow to the works. This isn't supported in the cloud yet.
As an App Builder, you are meant to ensure changes sent from the flow to the work can be applied e.g the current_value in the work hasn't been updated.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda