Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Introduce Bi-directional queues #15582

Merged
merged 66 commits into from
Nov 10, 2022
Merged

[App] Introduce Bi-directional queues #15582

merged 66 commits into from
Nov 10, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 8, 2022

What does this PR do?

This PR enables bi-directional queues from the flow to the works. This isn't supported in the cloud yet.

As an App Builder, you are meant to ensure changes sent from the flow to the work can be applied e.g the current_value in the work hasn't been updated.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 8, 2022
@tchaton tchaton marked this pull request as ready for review November 8, 2022 12:17
@mergify mergify bot added the has conflicts label Nov 8, 2022
@mergify mergify bot removed the has conflicts label Nov 8, 2022
@tchaton tchaton changed the title Introduce Bi-directional queues [App] Introduce Bi-directional queues Nov 8, 2022
@tchaton tchaton disabled auto-merge November 10, 2022 10:03
@tchaton tchaton enabled auto-merge (squash) November 10, 2022 10:09
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Nov 10, 2022
@lantiga lantiga disabled auto-merge November 10, 2022 11:21
@lantiga lantiga merged commit 10cdf0d into master Nov 10, 2022
@lantiga lantiga deleted the bi_queues branch November 10, 2022 11:21
@carmocca carmocca added this to the v1.8.x milestone Nov 10, 2022
Borda pushed a commit that referenced this pull request Nov 10, 2022
* update

* update

* update

* update

* update

* udpate

* update

* update

* update

* update

* update

* updatre

* update

* update

* update

* updar

* update

* update

* update

* remove print

* update

* update

* update

* update

* update

* update

* update

* update

(cherry picked from commit 10cdf0d)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
* update

* update

* update

* update

* update

* udpate

* update

* update

* update

* update

* update

* updatre

* update

* update

* update

* updar

* update

* update

* update

* remove print

* update

* update

* update

* update

* update

* update

* update

* update

(cherry picked from commit 10cdf0d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants