Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix result transfer in multiprocessing launcher on multi-node #15567

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Fix result transfer in multiprocessing launcher on multi-node #15567

merged 11 commits into from
Nov 8, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 7, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #15556

The added test fails on master.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @awaelchli @akihironitta

@awaelchli awaelchli self-assigned this Nov 7, 2022
@awaelchli awaelchli added the bug Something isn't working label Nov 7, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 7, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 7, 2022
@awaelchli awaelchli force-pushed the bugfix/multi-node-spawn branch from e38f98a to 1fa48c8 Compare November 8, 2022 00:15
@awaelchli awaelchli marked this pull request as ready for review November 8, 2022 00:18
@justusschock justusschock enabled auto-merge (squash) November 8, 2022 12:07
@justusschock justusschock merged commit 7767fd3 into master Nov 8, 2022
@justusschock justusschock deleted the bugfix/multi-node-spawn branch November 8, 2022 12:08
@mergify mergify bot added the ready PRs ready to be merged label Nov 8, 2022
Borda pushed a commit that referenced this pull request Nov 8, 2022
@awaelchli @Borda
Fix result transfer in multiprocessing launcher on multi-node (#15567)
a25df11 
* Fix result transfer in multiprocessing launcher on multi-node

* add simple test

* add comment

* update test

* changelog

* use tempfile

* fix

* assert None

* unused import

* add comment

(cherry picked from commit 7767fd3)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@awaelchli @lexierule
Fix result transfer in multiprocessing launcher on multi-node (#15567)
860a89b 
* Fix result transfer in multiprocessing launcher on multi-node

* add simple test

* add comment

* update test

* changelog

* use tempfile

* fix

* assert None

* unused import

* add comment

(cherry picked from commit 7767fd3)
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@carmocca carmocca carmocca approved these changes

Assignees

@awaelchli awaelchli

Labels
bug Something isn't working pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

DDP Spawn breaks when worker_output is None
3 participants
@awaelchli @carmocca @justusschock