Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] Fixed Multi Node and add examples #15557

Merged
merged 36 commits into from
Nov 7, 2022
Merged

[App] Fixed Multi Node and add examples #15557

merged 36 commits into from
Nov 7, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 6, 2022 •
edited by github-actions bot
Loading

What does this PR do?

This PR resolves some bugs with the Multi Node components and add some example and tests.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton self-assigned this Nov 6, 2022
@tchaton tchaton added the app (removed) Generic label for Lightning App package label Nov 6, 2022
@tchaton tchaton added the bug Something isn't working label Nov 6, 2022
@tchaton tchaton changed the title Improve Multi Node Example Fixed Multi Node and add examples Nov 6, 2022
@tchaton tchaton changed the title Fixed Multi Node and add examples [App] Fixed Multi Node and add examples Nov 6, 2022
@tchaton tchaton requested a review from lantiga November 6, 2022 15:05
@mergify mergify bot added the ready PRs ready to be merged label Nov 6, 2022
@tchaton tchaton enabled auto-merge (squash) November 6, 2022 15:52
lantiga
lantiga approved these changes Nov 6, 2022
View reviewed changes
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have a naming suggestion that IMO makes things a bit clearer.

examples/app_multi_node/app_pl_work.py Outdated Show resolved Hide resolved
examples/app_multi_node/app_torch_work.py Outdated Show resolved Hide resolved
@williamFalcon williamFalcon added this to the v1.8.x milestone Nov 6, 2022
rohitgr7
rohitgr7 approved these changes Nov 6, 2022
View reviewed changes
src/lightning_app/components/multi_node.py Outdated Show resolved Hide resolved
examples/app_multi_node/app_torch_work.py Show resolved Hide resolved
@tchaton tchaton merged commit 8202331 into master Nov 7, 2022
@tchaton tchaton deleted the add_multi_node_examples branch November 7, 2022 09:36
Borda pushed a commit that referenced this pull request Nov 8, 2022
@tchaton @Borda
[App] Fixed Multi Node and add examples (#15557)
e88e0fe 
(cherry picked from commit 8202331)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@tchaton @lexierule
[App] Fixed Multi Node and add examples (#15557)
77e21e5 
(cherry picked from commit 8202331)
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@manskx manskx manskx approved these changes

@williamFalcon williamFalcon williamFalcon approved these changes

@lantiga lantiga lantiga approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@hhsecond hhsecond Awaiting requested review from hhsecond

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees

@tchaton tchaton

Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
No open projects
Frameworks Planning
Status: Done
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.
5 participants
@tchaton @lantiga @williamFalcon @manskx @rohitgr7