Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let metadata score be serializable by wand #15544

Merged
merged 7 commits into from
Nov 5, 2022
Merged

Let metadata score be serializable by wand #15544

merged 7 commits into from
Nov 5, 2022

Conversation

geoffrey-g-delhomme
Copy link
Contributor

@geoffrey-g-delhomme geoffrey-g-delhomme commented Nov 4, 2022 •
edited by awaelchli
Loading

What does this PR do?

Fixes #15543

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Make sure you had fun coding 🙃

=> always!

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 4, 2022
@awaelchli awaelchli added bug Something isn't working logger: wandb Weights & Biases labels Nov 4, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Nov 4, 2022
@awaelchli awaelchli mentioned this pull request Nov 5, 2022
Merged
11 tasks
awaelchli
awaelchli approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! I took the liberty to add a test to avoid regression in the future.

@awaelchli awaelchli added the community This PR is from the community label Nov 5, 2022
@awaelchli awaelchli self-assigned this Nov 5, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 5, 2022
@awaelchli awaelchli changed the title Let metadata scorebe serializable by wand Let metadata score be serializable by wand Nov 5, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 5, 2022 14:21
@awaelchli awaelchli merged commit 7bdfced into Lightning-AI:master Nov 5, 2022
@geoffrey-g-delhomme geoffrey-g-delhomme deleted the bug/15543 branch November 5, 2022 18:21
Borda pushed a commit that referenced this pull request Nov 8, 2022
@geoffrey-g-delhomme @Borda
Let metadata score be serializable by wand (#15544)
ea7d193 
Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 7bdfced)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@geoffrey-g-delhomme @lexierule
Let metadata score be serializable by wand (#15544)
4719eb0 
Co-authored-by: awaelchli <[email protected]>
(cherry picked from commit 7bdfced)
@manangoel99 manangoel99 mentioned this pull request Nov 11, 2022
Closed
12 tasks
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@otaj otaj Awaiting requested review from otaj

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

Assignees

@awaelchli awaelchli

Labels
bug Something isn't working community This PR is from the community logger: wandb Weights & Biases pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.

Weights & Biases log_model error
3 participants
@geoffrey-g-delhomme @awaelchli @carmocca