Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly safer multi node #15538

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Slightly safer multi node #15538

merged 2 commits into from
Nov 5, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 4, 2022 •
edited by github-actions bot
Loading

What does this PR do?

After reading again the Multi-Node Component, it is possible to get locked when status changes. Better to isolate start from the rest of the execution.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 4, 2022
@lantiga lantiga added this to the v1.8.x milestone Nov 4, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2022
@williamFalcon williamFalcon merged commit d48aa03 into master Nov 5, 2022
@williamFalcon williamFalcon deleted the safer_multi_node branch November 5, 2022 02:05
Borda pushed a commit that referenced this pull request Nov 8, 2022
@tchaton @Borda
Slightly safer multi node (#15538)
e218619 
update

Co-authored-by: Luca Antiga <[email protected]>
(cherry picked from commit d48aa03)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@tchaton @lexierule
Slightly safer multi node (#15538)
e3b9f04 
update

Co-authored-by: Luca Antiga <[email protected]>
(cherry picked from commit d48aa03)
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manskx manskx manskx approved these changes

@lantiga lantiga lantiga approved these changes

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.
4 participants
@tchaton @lantiga @manskx @williamFalcon