Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App] Hot Fix: Missing root flow in app.flows #15531

Merged
merged 3 commits into from
Nov 4, 2022
Merged

[App] Hot Fix: Missing root flow in app.flows #15531

merged 3 commits into from
Nov 4, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 4, 2022

What does this PR do?

This change introduce the bug: 921dc1c#diff-6cbbb993a8c2bf30a487086dcd4cf9a595ffc7399ecfc3efbb79f7568a3b74c8L287.

The root flow should be listed among the flows.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton added bug Something isn't working app (removed) Generic label for Lightning App package labels Nov 4, 2022
@tchaton tchaton self-assigned this Nov 4, 2022
@tchaton tchaton requested a review from hhsecond as a code owner November 4, 2022 13:57
@tchaton tchaton requested a review from lantiga as a code owner November 4, 2022 13:58
@mergify mergify bot added the ready PRs ready to be merged label Nov 4, 2022
@tchaton tchaton enabled auto-merge (squash) November 4, 2022 14:03
@awaelchli awaelchli added this to the v1.8.x milestone Nov 4, 2022
@tchaton tchaton merged commit 1824ad0 into master Nov 4, 2022
@tchaton tchaton deleted the hot_fix_app branch November 4, 2022 15:00
Borda pushed a commit that referenced this pull request Nov 5, 2022
lexierule pushed a commit that referenced this pull request Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants