Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse existing commands when running connect more than once #15471

Merged
merged 15 commits into from
Nov 7, 2022
Merged

Reuse existing commands when running connect more than once #15471

merged 15 commits into from
Nov 7, 2022

Conversation

lantiga
Copy link
Collaborator

@lantiga lantiga commented Nov 2, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Everytime we connect, we download all commands from scratch, which slows down the experience. This PR copies the commands and connect file from an active connection, if it exists.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 2, 2022
@lantiga lantiga marked this pull request as draft November 2, 2022 10:47
@lantiga lantiga changed the title Reuse connection Reuse existing connection when connecting multiple times from the same machine Nov 2, 2022
@lantiga lantiga changed the title Reuse existing connection when connecting multiple times from the same machine Reuse existing commands when running connect more than once Nov 2, 2022
@lantiga lantiga marked this pull request as ready for review November 4, 2022 23:29
@lantiga lantiga added this to the v1.8.x milestone Nov 4, 2022
awaelchli
awaelchli reviewed Nov 5, 2022
View reviewed changes
src/lightning_app/cli/commands/connection.py Outdated Show resolved Hide resolved
tests/tests_app/cli/test_connect.py Outdated Show resolved Hide resolved
@lantiga lantiga requested a review from awaelchli November 7, 2022 09:36
tchaton
tchaton approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

awaelchli
awaelchli approved these changes Nov 7, 2022
View reviewed changes
tests/tests_app/cli/test_connect.py Outdated Show resolved Hide resolved
tests/tests_app/cli/test_connect.py Outdated Show resolved Hide resolved
tests/tests_app/cli/test_connect.py Outdated Show resolved Hide resolved
tests/tests_app/cli/test_connect.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 7, 2022
@Borda Borda requested a review from manskx November 7, 2022 19:57
@Borda Borda enabled auto-merge (squash) November 7, 2022 19:58
@Borda Borda merged commit 01f57a9 into master Nov 7, 2022
@Borda Borda deleted the reuse_connection branch November 7, 2022 20:01
Borda pushed a commit that referenced this pull request Nov 8, 2022
@lantiga @Borda
Reuse existing commands when running connect more than once (#15471)
507ba37 
* Reuse connection if it matches a connection from an active terminal
* Remove unused import
* Include both name and id in the check
* Fix messages and tests
* Add test
* Handle monkeypatching more cleanly
* Remove unused imports

Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 01f57a9)
lexierule pushed a commit that referenced this pull request Nov 10, 2022
@lantiga @lexierule
Reuse existing commands when running connect more than once (#15471)
6c199e9 
* Reuse connection if it matches a connection from an active terminal
* Remove unused import
* Include both name and id in the check
* Fix messages and tests
* Add test
* Handle monkeypatching more cleanly
* Remove unused imports

Co-authored-by: Luca Antiga <[email protected]>
Co-authored-by: thomas chaton <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 01f57a9)
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@hhsecond hhsecond Awaiting requested review from hhsecond

@manskx manskx Awaiting requested review from manskx

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.
5 participants
@lantiga @awaelchli @manskx @tchaton @Borda