Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pytest as a requirement to run app #15449

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Remove pytest as a requirement to run app #15449

merged 2 commits into from
Nov 2, 2022

Conversation

manskx
Copy link
Contributor

@manskx manskx commented Nov 1, 2022 •
edited by github-actions bot
Loading

What does this PR do?

This PR just moves the import of pytest to avoid importing if the app cannot be loaded locally, as it imports EmptyFlow.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@manskx manskx marked this pull request as ready for review November 1, 2022 14:34
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Nov 1, 2022
@mergify mergify bot added the ready PRs ready to be merged label Nov 1, 2022
@manskx manskx enabled auto-merge (squash) November 1, 2022 16:56
@akihironitta akihironitta added this to the v1.8.x milestone Nov 1, 2022
@Borda Borda added the priority: 0 High priority task label Nov 2, 2022
@kaushikb11
Copy link
Contributor

@tchaton @lantiga for review!

@manskx
Copy link
Contributor Author

manskx commented Nov 2, 2022

@tchaton @lantiga Can I get a review from you as a codeowner on this ? as merging is blocked

@manskx manskx merged commit 0421d6b into master Nov 2, 2022
@manskx manskx deleted the manskx/app/remove-pytest-as-requirement-to-run-app branch November 2, 2022 16:03
Borda pushed a commit that referenced this pull request Nov 2, 2022
@manskx @Borda
Remove pytest as a requirement to run app (#15449)
7e3b5c4 
* Remove pytest as a requirment to run app

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 0421d6b)
@nicolai86 nicolai86 mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@otaj otaj otaj approved these changes

@Borda Borda Borda approved these changes

@lantiga lantiga lantiga approved these changes

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

Assignees
No one assigned
Labels
app (removed) Generic label for Lightning App package priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
v1.8.x
Development

Successfully merging this pull request may close these issues.
6 participants
@manskx @kaushikb11 @lantiga @Borda @otaj @akihironitta