Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg: fix parsing versions #15401

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Pkg: fix parsing versions #15401

merged 5 commits into from
Nov 1, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 28, 2022

What does this PR do?

if the version range is not lowe-upper bound, it is caster wrongly

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added the bug Something isn't working label Oct 28, 2022
@Borda Borda added this to the v1.8.x milestone Oct 28, 2022
@Borda Borda marked this pull request as ready for review October 28, 2022 22:40
@Borda Borda enabled auto-merge (squash) October 28, 2022 22:41
@Borda Borda requested a review from akihironitta October 31, 2022 11:17
.actions/setup_tools.py Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Oct 31, 2022
@Borda Borda merged commit c0149d8 into master Nov 1, 2022
@Borda Borda deleted the pkg/fix-version branch November 1, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants