-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Launch options for Lightning Lite #14992
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
force-pushed
the
lite/launcher-poc
branch
from
October 4, 2022 11:01
78fb0b5
to
ec164b9
Compare
for more information, see https://pre-commit.ci
awaelchli
added
feature
Is an improvement or enhancement
fabric
lightning.fabric.Fabric
and removed
pl
Generic label for PyTorch Lightning package
labels
Oct 5, 2022
awaelchli
requested review from
carmocca,
justusschock and
rohitgr7
as code owners
October 5, 2022 15:49
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Nov 1, 2022
Borda
reviewed
Nov 1, 2022
Co-authored-by: Jirka Borovec <[email protected]>
for more information, see https://pre-commit.ci
@awaelchli Looks great and I really like |
carmocca
approved these changes
Nov 2, 2022
Co-authored-by: Carlos Mocholí <[email protected]>
for more information, see https://pre-commit.ci
… into lite/launcher-poc
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Subclassing and overriding
LightningLite.run()
is no longer required. You can create and use theLightningLite
object directly:To launch the script, a special CLI needs to be used:
The command above will eventually become
lightning run ...
in the future.Alternatively, one can launch programmatically:
In Jupyter notebooks (Colab, Kaggle etc.) you would launch like this:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @carmocca @justusschock @awaelchli