Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSDP (native) support for LightningLite #14967

Merged
merged 108 commits into from
Nov 21, 2022
Merged

FSDP (native) support for LightningLite #14967

merged 108 commits into from
Nov 21, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 1, 2022

What does this PR do?

Adds support for strategy="fsdp" in LightningLite.

Fixes #14898

TODOs:

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @carmocca @justusschock @awaelchli

@awaelchli awaelchli added fabric lightning.fabric.Fabric feature Is an improvement or enhancement labels Oct 1, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 1, 2022
@awaelchli awaelchli added strategy: fsdp Fully Sharded Data Parallel and removed pl Generic label for PyTorch Lightning package labels Oct 1, 2022
@awaelchli awaelchli added this to the pl:future milestone Oct 1, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 1, 2022
@awaelchli awaelchli added this to the v1.9 milestone Nov 20, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 20, 2022
@awaelchli awaelchli marked this pull request as ready for review November 20, 2022 20:48
@mergify mergify bot added the ready PRs ready to be merged label Nov 21, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli added fun Staff contributions outside working hours - to differentiate from the "community" label and removed community This PR is from the community labels Nov 21, 2022
@awaelchli awaelchli enabled auto-merge (squash) November 21, 2022 13:13
@awaelchli awaelchli merged commit 8656852 into master Nov 21, 2022
@awaelchli awaelchli deleted the lite/fsdp branch November 21, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fabric lightning.fabric.Fabric feature Is an improvement or enhancement fun Staff contributions outside working hours - to differentiate from the "community" label pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: fsdp Fully Sharded Data Parallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FSDP in Lite
5 participants