-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FSDP (native) support for LightningLite #14967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
fabric
lightning.fabric.Fabric
feature
Is an improvement or enhancement
labels
Oct 1, 2022
awaelchli
added
strategy: fsdp
Fully Sharded Data Parallel
and removed
pl
Generic label for PyTorch Lightning package
labels
Oct 1, 2022
awaelchli
commented
Nov 20, 2022
tests/tests_pytorch/strategies/test_ddp_fully_sharded_native.py
Outdated
Show resolved
Hide resolved
awaelchli
requested review from
carmocca,
justusschock and
williamFalcon
as code owners
November 20, 2022 20:48
justusschock
approved these changes
Nov 21, 2022
Borda
approved these changes
Nov 21, 2022
tchaton
approved these changes
Nov 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
carmocca
approved these changes
Nov 21, 2022
awaelchli
added
fun
Staff contributions outside working hours - to differentiate from the "community" label
and removed
community
This PR is from the community
labels
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for
strategy="fsdp"
in LightningLite.Fixes #14898
TODOs:
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @carmocca @justusschock @awaelchli