-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: option to add custom meta tags to the UI container #14915
feat: option to add custom meta tags to the UI container #14915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I share same concerns with Thomas about the dependency. Have we looked at the code, are we happy with how it is maintained, how heavy/light it is etc?
bs4 is around 2MB in size, @awaelchli. I think we should just use it instead of writing parsers from scratch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock releasing!
(cherry picked from commit 2721a2f)
(cherry picked from commit 2721a2f)
What does this PR do?
feature to allow users to add custom meta tags directly to the lightning app.
under the hood, it writes these tags to
index.html
as the last step in the LightningApp constructor.Limitation
if a user runs multiple apps on a single machine at the same time the latest tags will be visible in all the apps.
image should be a valid url, rn users cannot provide a local filesystem path.
need to update docs
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃