Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to add custom meta tags to the UI container #14915

Merged
merged 1 commit into from
Sep 30, 2022
Merged

feat: option to add custom meta tags to the UI container #14915

merged 1 commit into from
Sep 30, 2022

Conversation

pritamsoni-hsr
Copy link
Contributor

@pritamsoni-hsr pritamsoni-hsr commented Sep 27, 2022

What does this PR do?

feature to allow users to add custom meta tags directly to the lightning app.

under the hood, it writes these tags to index.html as the last step in the LightningApp constructor.

Limitation

if a user runs multiple apps on a single machine at the same time the latest tags will be visible in all the apps.

image should be a valid url, rn users cannot provide a local filesystem path.

need to update docs

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 27, 2022
requirements/app/base.txt Outdated Show resolved Hide resolved
src/lightning_app/utilities/add_meta.py Outdated Show resolved Hide resolved
@pritamsoni-hsr pritamsoni-hsr changed the title feat: option to add custom meta tags to the UI container [skip ci] feat: option to add custom meta tags to the UI container Sep 29, 2022
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@mergify mergify bot added the ready PRs ready to be merged label Sep 29, 2022
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I share same concerns with Thomas about the dependency. Have we looked at the code, are we happy with how it is maintained, how heavy/light it is etc?

src/lightning_app/utilities/add_meta.py Outdated Show resolved Hide resolved
src/lightning_app/core/app.py Outdated Show resolved Hide resolved
@kaushikb11 kaushikb11 added this to the app:0.7 milestone Sep 29, 2022
@pritamsoni-hsr
Copy link
Contributor Author

bs4 is around 2MB in size, @awaelchli. I think we should just use it instead of writing parsers from scratch.

@pritamsoni-hsr pritamsoni-hsr requested review from manskx and awaelchli and removed request for manskx September 29, 2022 17:27
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock releasing!

@rohitgr7 rohitgr7 merged commit 2721a2f into Lightning-AI:master Sep 30, 2022
@pritamsoni-hsr pritamsoni-hsr deleted the pritam/add-meta-tags branch September 30, 2022 13:37
Borda pushed a commit that referenced this pull request Oct 5, 2022
lexierule pushed a commit that referenced this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants