Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-friendly exception if root flow does not override the run() method #14760

Merged
merged 2 commits into from
Sep 17, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 16, 2022

What does this PR do?

Part of #14677
Similar to #14759

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

update
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 16, 2022
@awaelchli awaelchli added this to the app:0.7 milestone Sep 16, 2022
@awaelchli awaelchli self-assigned this Sep 16, 2022
@awaelchli awaelchli added the feature Is an improvement or enhancement label Sep 16, 2022
@awaelchli awaelchli marked this pull request as ready for review September 16, 2022 21:54
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #14760 (9b50dcb) into master (35c65b0) will increase coverage by 1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #14760     +/-   ##
=========================================
+ Coverage      84%      85%     +1%     
=========================================
  Files         395      328     -67     
  Lines       28805    25777   -3028     
=========================================
- Hits        24087    21859   -2228     
+ Misses       4718     3918    -800     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 17, 2022
@tchaton tchaton merged commit 51ab51a into master Sep 17, 2022
@tchaton tchaton deleted the feature/run-method-validation-flow branch September 17, 2022 06:25
@krshrimali krshrimali modified the milestones: app:0.7, app:0.6.x Sep 18, 2022
@krshrimali
Copy link
Contributor

Moving the milestone to 0.6.x, as this is a helpful error. @awaelchli @tchaton - Is it okay? Feel free to move it back if 0.7 is the desired one.

@awaelchli
Copy link
Contributor Author

If this was for Trainer, we wouldn't add it to the patch release, because it is not a bugfix. I don't know how strict we are on the app side, so redirecting this question to @Borda @tchaton.

Borda pushed a commit that referenced this pull request Sep 20, 2022
lexierule pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package feature Is an improvement or enhancement ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants