Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lightning cloud for memory leak fix #14697

Merged
merged 10 commits into from
Sep 15, 2022
Merged

Bump lightning cloud for memory leak fix #14697

merged 10 commits into from
Sep 15, 2022

Conversation

hhsecond
Copy link
Contributor

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 14, 2022
@hhsecond hhsecond self-assigned this Sep 14, 2022
@hhsecond hhsecond added this to the app:0.6.x milestone Sep 14, 2022
@hhsecond hhsecond marked this pull request as ready for review September 15, 2022 05:14
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli added the bug Something isn't working label Sep 15, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2022
@hhsecond hhsecond marked this pull request as draft September 15, 2022 08:12
@hhsecond hhsecond marked this pull request as ready for review September 15, 2022 11:36
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #14697 (973b719) into master (75e6c91) will increase coverage by 1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #14697     +/-   ##
=========================================
+ Coverage      84%      85%     +1%     
=========================================
  Files         394      327     -67     
  Lines       28604    25859   -2745     
=========================================
- Hits        23894    21951   -1943     
+ Misses       4710     3908    -802     

@hhsecond hhsecond merged commit 7dbd038 into master Sep 15, 2022
@hhsecond hhsecond deleted the bump-lightning-cloud branch September 15, 2022 12:29
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
Bump lightning cloud for memory leak fix (#14697)
@krshrimali krshrimali mentioned this pull request Sep 16, 2022
12 tasks
lexierule pushed a commit that referenced this pull request Sep 19, 2022
Bump lightning cloud for memory leak fix (#14697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants