-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightning cloud client call with key word arguments #14685
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Sep 13, 2022
for more information, see https://pre-commit.ci
…tning into lightning-cloud-import
for more information, see https://pre-commit.ci
…tning into lightning-cloud-import
for more information, see https://pre-commit.ci
hhsecond
requested review from
tchaton,
awaelchli and
manskx
as code owners
September 13, 2022 17:29
hhsecond
changed the title
Lightning cloud import fixes
Lightning cloud client call with key word arguments
Sep 13, 2022
awaelchli
approved these changes
Sep 13, 2022
@hhsecond Could you add the desired milestone? I wasn't sure, thanks |
Codecov Report
@@ Coverage Diff @@
## master #14685 +/- ##
=========================================
Coverage 85% 85%
=========================================
Files 381 327 -54
Lines 27634 25829 -1805
=========================================
- Hits 23364 21950 -1414
+ Misses 4270 3879 -391 |
tchaton
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat !
krshrimali
pushed a commit
that referenced
this pull request
Sep 16, 2022
12 tasks
lexierule
pushed a commit
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We recently had changed the OpenAPI client to be generated using latest swagger CLI (the older one had a nasty memory leak) which is forcing us to use the generated client calls to be using key value arguments instead of positional arguments. This PR converts all our client call to have key value arguments
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃