-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Reuse clear cache #14593
CI: Reuse clear cache #14593
Conversation
|
c355095
to
f9f95dd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #14593 +/- ##
========================================
- Coverage 84% 83% -1%
========================================
Files 395 395
Lines 28871 28871
========================================
- Hits 24213 23885 -328
- Misses 4658 4986 +328 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Low confidence approval. How do we know this worked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carmocca Thank you for your review!
Low confidence approval. How do we know this worked?
We can try running this workflow on this PR once, but that will increase the testing time across (almost) all PRs in this repository. I can test it out this weekend and will paste the link to the job run to make sure that it resets these caches.
* Remove existing weekly reset logic * clear cache every week * Use main tag
What does this PR do?
Part of Lightning-AI/utilities#47.
clear-cache
.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda