Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Reuse clear cache #14593

Merged
merged 4 commits into from
Oct 5, 2022
Merged

CI: Reuse clear cache #14593

merged 4 commits into from
Oct 5, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Sep 8, 2022

What does this PR do?

Part of Lightning-AI/utilities#47.

  • Removes all existing weekly cache resetting.
  • Adds a workflow that clears caches in the repository with one of our reusable workflows, clear-cache.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta
Copy link
Contributor Author

akihironitta commented Sep 9, 2022

This PR is waiting for a new utilities release that includes clear-cache action.
https://github.com/Lightning-AI/utilities/
Will use @main instead.

@akihironitta akihironitta marked this pull request as ready for review September 29, 2022 12:27
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #14593 (4f37cc5) into master (a45c047) will decrease coverage by 1%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #14593    +/-   ##
========================================
- Coverage      84%      83%    -1%     
========================================
  Files         395      395            
  Lines       28871    28871            
========================================
- Hits        24213    23885   -328     
- Misses       4658     4986   +328     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Low confidence approval. How do we know this worked?

.github/workflows/schedule-clear-cache.yml Show resolved Hide resolved
Copy link
Contributor Author

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carmocca Thank you for your review!

Low confidence approval. How do we know this worked?

We can try running this workflow on this PR once, but that will increase the testing time across (almost) all PRs in this repository. I can test it out this weekend and will paste the link to the job run to make sure that it resets these caches.

@Borda Borda merged commit 2a65799 into master Oct 5, 2022
@Borda Borda deleted the ci/clear-cache branch October 5, 2022 09:52
@mergify mergify bot added the ready PRs ready to be merged label Oct 5, 2022
nicolai86 pushed a commit that referenced this pull request Oct 13, 2022
* Remove existing weekly reset logic
* clear cache every week
* Use main tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants