-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lightning App Fixes from Training Studio App dev #14532
Conversation
@tchaton could you add a description to this PR explaining what this PR is fixing ? This helps anyone who reviews the PR also for the changelog. |
@tchaton, any update here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems examples are failing on Windows:
Traceback (most recent call last):
File "c:\hostedtoolcache\windows\python\3.8.10\x64\lib\site-packages\pytest_timeout.py", line 424, in timeout_timer
stdout, stderr = capman.read_global_capture()
File "c:\hostedtoolcache\windows\python\3.8.10\x[64](https://github.com/Lightning-AI/lightning/actions/runs/3039117114/jobs/4893683157#step:12:65)\lib\site-packages\_pytest\capture.py", line 690, in read_global_capture
assert self._global_capturing is not None
AssertionError
Error: Process completed with exit code 1.
Codecov Report
@@ Coverage Diff @@
## master #14532 +/- ##
=========================================
+ Coverage 51% 85% +34%
=========================================
Files 381 327 -54
Lines 27575 25821 -1754
=========================================
+ Hits 14026 21934 +7908
+ Misses 13549 3887 -9662 |
What does this PR do?
This PR introduces several fixes or usability improvements done while developing the Training Studio App.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃