Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning App Fixes from Training Studio App dev #14532

Merged
merged 42 commits into from
Sep 13, 2022
Merged

Lightning App Fixes from Training Studio App dev #14532

merged 42 commits into from
Sep 13, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 4, 2022

What does this PR do?

This PR introduces several fixes or usability improvements done while developing the Training Studio App.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 4, 2022
@tchaton tchaton marked this pull request as ready for review September 4, 2022 15:54
@tchaton tchaton modified the milestones: app:0.6.x, app:0.6 Sep 4, 2022
@manskx
Copy link
Contributor

manskx commented Sep 5, 2022

@tchaton could you add a description to this PR explaining what this PR is fixing ? This helps anyone who reviews the PR also for the changelog.

@Borda
Copy link
Member

Borda commented Sep 6, 2022

@tchaton, any update here?

@carmocca carmocca modified the milestones: app:0.6, app:0.6.x Sep 7, 2022
src/lightning_app/core/app.py Outdated Show resolved Hide resolved
src/lightning_app/utilities/proxies.py Outdated Show resolved Hide resolved
src/lightning_app/core/app.py Outdated Show resolved Hide resolved
@tchaton tchaton marked this pull request as draft September 12, 2022 09:24
@tchaton tchaton changed the title Small fixes Lightning App Fixes from Training Studio App dev Sep 12, 2022
Borda
Borda previously requested changes Sep 12, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems examples are failing on Windows:

Traceback (most recent call last):
  File "c:\hostedtoolcache\windows\python\3.8.10\x64\lib\site-packages\pytest_timeout.py", line 424, in timeout_timer
    stdout, stderr = capman.read_global_capture()
  File "c:\hostedtoolcache\windows\python\3.8.10\x[64](https://github.com/Lightning-AI/lightning/actions/runs/3039117114/jobs/4893683157#step:12:65)\lib\site-packages\_pytest\capture.py", line 690, in read_global_capture
    assert self._global_capturing is not None
AssertionError
Error: Process completed with exit code 1.

@mergify mergify bot removed the ready PRs ready to be merged label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #14532 (d9ea213) into master (16b4644) will increase coverage by 34%.
The diff coverage is 53%.

❗ Current head d9ea213 differs from pull request most recent head 157b10b. Consider uploading reports for the commit 157b10b to get more accurate results

@@            Coverage Diff            @@
##           master   #14532     +/-   ##
=========================================
+ Coverage      51%      85%    +34%     
=========================================
  Files         381      327     -54     
  Lines       27575    25821   -1754     
=========================================
+ Hits        14026    21934   +7908     
+ Misses      13549     3887   -9662     

@mergify mergify bot removed the has conflicts label Sep 13, 2022
@Borda Borda dismissed their stale review September 13, 2022 15:11

lets see test results...

@mergify mergify bot added the ready PRs ready to be merged label Sep 13, 2022
@lexierule lexierule merged commit c81a71c into master Sep 13, 2022
@lexierule lexierule deleted the small_fixes branch September 13, 2022 15:43
@krshrimali krshrimali mentioned this pull request Sep 16, 2022
12 tasks
@tchaton tchaton added the bug Something isn't working label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants