-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(app) Resolve a bug where the state changes isn't detected properly #14465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
added
app (removed)
Generic label for Lightning App package
bug
Something isn't working
labels
Aug 31, 2022
tchaton
changed the title
(app) Resolve a bug where the state changes is detected properly
(app) Resolve a bug where the state changes isn't detected properly
Aug 31, 2022
manskx
reviewed
Aug 31, 2022
manskx
approved these changes
Aug 31, 2022
Co-authored-by: Mansy <[email protected]>
…-AI/lightning into resolve_has_update_bug
hhsecond
approved these changes
Aug 31, 2022
awaelchli
approved these changes
Aug 31, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 7, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Sep 12, 2022
krshrimali
pushed a commit
that referenced
this pull request
Sep 16, 2022
…14465) Co-authored-by: Mansy <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
12 tasks
lexierule
pushed a commit
that referenced
this pull request
Sep 19, 2022
…14465) Co-authored-by: Mansy <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
bug
Something isn't working
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The DeepDiff generates an unprocessed key for Path, Drive objects and therefore leads to wrong detection of state update. This PR converts Drive, Path objects to dict for DeepDiff to make a comparaison.
The test breaks on master.
Fixes #<issue_number>
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda