-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI] Fix cluster logs with over 5000 entries #14458
[CLI] Fix cluster logs with over 5000 entries #14458
Conversation
5c908f8
to
ecf89e5
Compare
f133fe6
to
e3ce0d9
Compare
4569a8e
to
841df78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once last comments are addressed.
This is blocked on prod release which support nanosecond precision timestamps for logs |
Codecov Report
@@ Coverage Diff @@
## master #14458 +/- ##
=========================================
+ Coverage 84% 85% +1%
=========================================
Files 391 327 -64
Lines 28306 25860 -2446
=========================================
- Hits 23764 21945 -1819
+ Misses 4542 3915 -627 |
c2c249c
to
0620283
Compare
7da69e0
to
cc2fbc7
Compare
9865aea
to
ae9803f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
088e0ab
to
bbfea2f
Compare
What does this PR do?
Fixes https://linear.app/lightning-ai/issue/GRID-10410/very-large-limits-say-10000-dont-work-error-400 partially.
Today if you try to fetch gridv1.Cluster logs in the CLI and want more than 5000 lines it'll brake due to internal limitations. This PR implements batching, thus we're fetching 5000 by 5000 log lines from the API server.
Does your PR introduce any breaking changes? If yes, please list them.
No
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Limitations
Test plan
n-020
cluster logsDid you have fun?
Make sure you had fun coding 🙃
cc @Borda