Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[App][CLI] Fix lightning cli --version #14433

Merged
merged 6 commits into from
Sep 1, 2022
Merged

Conversation

manskx
Copy link
Contributor

@manskx manskx commented Aug 29, 2022

What does this PR do?

Fixes #14410

Also deleting some dead code.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 29, 2022
@awaelchli awaelchli added this to the app:0.6.x milestone Aug 29, 2022
@awaelchli
Copy link
Contributor

We could add a changelog entry as well

@mergify mergify bot added the ready PRs ready to be merged label Aug 29, 2022
@manskx
Copy link
Contributor Author

manskx commented Aug 29, 2022

We could add a changelog entry as well

added

@manskx manskx enabled auto-merge (squash) August 29, 2022 13:15
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 31, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Sep 1, 2022
@manskx manskx merged commit 1bcb5c3 into master Sep 1, 2022
@manskx manskx deleted the manskx/app/fix-lightning-app-cli branch September 1, 2022 07:58
@Borda Borda modified the milestones: app:0.6.x, app:0.6 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix lightning --version cmd
5 participants