Fix property setter override by default setter

[pranjaldatta]

What does this PR do?

Fixes a bug within LightningWork class wherein properties with custom __setter__ defined get overridden by the default __setter__, which would lead to JSON Serialization errors.

Fixes #13934

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes

[pranjaldatta]

@hhsecond This is the PR regarding the issue #14259. There are some cloud related tests failing which at a glance seem like something to do with invalid URL / token issues, i.e., unrelated to this PR.

[hhsecond]

@pranjaldatta Awesome. Thank you for the PR. I just found that we have an issue (#13927) with running cloud test on PRs from forked repo. We'd need to wait for that to be fixed unfortunately :(

[pranjaldatta]

@pranjaldatta Awesome. Thank you for the PR. I just found that we have an issue (#13927) with running cloud test on PRs from forked repo. We'd need to wait for that to be fixed unfortunately :(

Understood! No worries!

[pranjaldatta]

Hi @hhsecond, I see that #13927 was just closed but during the cloud E2E tests, I see this error https://dev.azure.com/Lightning-AI/lightning/_build/results?buildId=92543&view=logs&j=4f63abee-993d-5237-1fd4-9fc286c82252&t=d8e19db7-f33f-5cff-ead3-b7436d0cd5e5&l=618. It seems like there is some issue with this particular test file.

[hhsecond]

The tagged issue was fixed 2 days ago but I see some of the tests are failing in the e2e pipeline. Probably flaky tests but lemme take a look

[awaelchli]

Looks great

[tchaton]

Looks great ! Great contribution !