Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when http URLs are configured #14233

Merged
merged 7 commits into from
Aug 17, 2022
Merged

Warn when http URLs are configured #14233

merged 7 commits into from
Aug 17, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 16, 2022

What does this PR do?

Fixes #14230

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

@awaelchli awaelchli added app (removed) Generic label for Lightning App package feature Is an improvement or enhancement labels Aug 16, 2022
@awaelchli awaelchli added this to the app:0.6 milestone Aug 16, 2022
@awaelchli awaelchli marked this pull request as ready for review August 16, 2022 14:55
@awaelchli awaelchli requested a review from alecmerdler August 16, 2022 14:56
src/lightning_app/utilities/layout.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 17, 2022
@mergify mergify bot requested a review from a team August 17, 2022 05:41
@krishnakalyan3
Copy link
Contributor

LGTM

@lexierule lexierule merged commit 7c329dd into master Aug 17, 2022
@lexierule lexierule deleted the feature/warn-http branch August 17, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package feature Is an improvement or enhancement ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Explain that configure_layout URLs get embedded in iframes
8 participants