-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix install latest version of app/component #14181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manskx
changed the title
fix install latest version of app/component
Fix install latest version of app/component
Aug 12, 2022
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Aug 12, 2022
Borda
approved these changes
Aug 12, 2022
awaelchli
approved these changes
Aug 14, 2022
Borda
pushed a commit
that referenced
this pull request
Aug 16, 2022
* fix install latest version of app/component * Add changelog * a better testcase * Update src/lightning_app/CHANGELOG.md Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 562d22f)
lexierule
pushed a commit
that referenced
this pull request
Aug 18, 2022
* fix install latest version of app/component * Add changelog * a better testcase * Update src/lightning_app/CHANGELOG.md Co-authored-by: mansy <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 562d22f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14178
where lightning install should install latest version by default.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @tchaton @rohitgr7