Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install latest version of app/component #14181

Merged
merged 5 commits into from
Aug 15, 2022

Conversation

manskx
Copy link
Contributor

@manskx manskx commented Aug 12, 2022

What does this PR do?

Fixes #14178

where lightning install should install latest version by default.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@manskx manskx changed the title fix install latest version of app/component Fix install latest version of app/component Aug 12, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 12, 2022
@manskx manskx self-assigned this Aug 12, 2022
@manskx manskx added this to the app:0.5.x milestone Aug 12, 2022
@manskx manskx marked this pull request as ready for review August 12, 2022 10:47
src/lightning_app/CHANGELOG.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Aug 14, 2022
@mergify mergify bot requested a review from a team August 14, 2022 22:54
@awaelchli awaelchli added the priority: 0 High priority task label Aug 15, 2022
@manskx manskx enabled auto-merge (squash) August 15, 2022 12:35
@lexierule lexierule disabled auto-merge August 15, 2022 13:31
@lexierule lexierule merged commit 562d22f into master Aug 15, 2022
@lexierule lexierule deleted the fix-install-cmd-latest-version branch August 15, 2022 13:31
Borda pushed a commit that referenced this pull request Aug 16, 2022
* fix install latest version of app/component

* Add changelog

* a better testcase

* Update src/lightning_app/CHANGELOG.md

Co-authored-by: mansy <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

(cherry picked from commit 562d22f)
lexierule pushed a commit that referenced this pull request Aug 18, 2022
* fix install latest version of app/component

* Add changelog

* a better testcase

* Update src/lightning_app/CHANGELOG.md

Co-authored-by: mansy <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>

(cherry picked from commit 562d22f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package priority: 0 High priority task ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Lightning install app <app_name> doesn't get the latest app version
4 participants