[CLI] change cluster creation cost savings mode default #14132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolai86
requested review from
tchaton,
awaelchli,
manskx and
hhsecond
as code owners
github-actions
bot
added
the
app (removed)
hhsecond
approved these changes
Aug 10, 2022
|
Do we have the "cluster" feature documented already? |
|
Wouldn't it make sense to turn it around and have an |
I agree, avoiding the negation makes the flag more readable. let me change that. |
lantiga
approved these changes
Aug 10, 2022
the documentation is in a pending PR, I'll leave a comment to adjust it according to this change. @hhsecond |
manskx
reviewed
Aug 10, 2022
manskx
approved these changes
Aug 10, 2022
instead of having customers opt-into cost savings mode, we'll ask them to opt-out of cost savings mode.
--disable-cost-savings is less clear than --enable-performance
nicolai86
force-pushed
the
nicolai86/cluster-creation-defaults
branch
from
1407e40 to
7715b1a
Compare
jessecambon
pushed a commit
to jessecambon/lightning
that referenced
this pull request
Aug 16, 2022
…#14132) * [CLI] change cluster creation cost savings mode default instead of having customers opt-into cost savings mode, we'll ask them to opt-out of cost savings mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes the default for cluster creation:
instead of having customers opt-into cost savings mode, we'll ask them to opt-out of cost savings mode.
Based on internal discussions - see LAI2-10134
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda