Update Grid links to Lightning AI #14081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was wondering on how to proceed here as this would also implicate changes for the following files |
krishnakalyan3
requested review from
williamFalcon,
edenlightning,
Borda,
tchaton,
carmocca,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
awaelchli
approved these changes
Aug 8, 2022
rohitgr7
approved these changes
Aug 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #14081 +/- ##
=========================================
+ Coverage 61% 76% +15%
=========================================
Files 324 324
Lines 26342 26378 +36
=========================================
+ Hits 16139 20112 +3973
+ Misses 10203 6266 -3937 |
Co-authored-by: Adrian Wälchli <[email protected]>
awaelchli
changed the title
otaj
approved these changes
Aug 9, 2022
kaushikb11
reviewed
Aug 9, 2022
| @@ -1,2 +1,2 @@ | |||
| developer@grid.ai | |||
| developer@lightning.ai | |||
There was a problem hiding this comment.
@krishnakalyan3 @Borda could we do a sanity check to this address?
kaushikb11
approved these changes
Aug 9, 2022
Borda
approved these changes
Aug 10, 2022
Borda
pushed a commit
that referenced
this pull request
Aug 16, 2022
* initial changes for lightning * Update .github/BECOMING_A_CORE_CONTRIBUTOR.md Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 5801484)
jessecambon
pushed a commit
to jessecambon/lightning
that referenced
this pull request
Aug 16, 2022
* initial changes for lightning * Update .github/BECOMING_A_CORE_CONTRIBUTOR.md Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]>
lexierule
pushed a commit
that referenced
this pull request
Aug 18, 2022
* initial changes for lightning * Update .github/BECOMING_A_CORE_CONTRIBUTOR.md Co-authored-by: Adrian Wälchli <[email protected]> Co-authored-by: Adrian Wälchli <[email protected]> (cherry picked from commit 5801484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes Lightning-Universe/lightning_sphinx_theme#54