-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(app) Run the flow only if the state has updated 1/2 #14076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that we're getting to this, really important.
It checks out, I've mostly got a question around the scheduler test.
…ning-AI/lightning into serverless_breaking_change
…ning-AI/lightning into serverless_breaking_change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on the scheduler frequency. We should keep it at a second granularity (so 0.5 timeout is fine) and document it, and just patch it during testing to make tests faster.
What does this PR do?
This PR introduces a breaking change where the flow will execute only if the state changes. This is required in order to move toward a serverless expression of the flow. This still triggers if the flow modifies its own state which we might want to disable in the future, but I believe this is required for now.
Does your PR introduce any breaking changes? If yes, please list them.
Yes, this used to print infinitely on master, but now this will print only once as no state was modified.
Parts of Lightning-AI/lightning-app#938
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda