Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(app) Run the flow only if the state has updated 1/2 #14076

Merged
merged 19 commits into from
Aug 10, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Aug 7, 2022

What does this PR do?

This PR introduces a breaking change where the flow will execute only if the state changes. This is required in order to move toward a serverless expression of the flow. This still triggers if the flow modifies its own state which we might want to disable in the future, but I believe this is required for now.

Does your PR introduce any breaking changes? If yes, please list them.

Yes, this used to print infinitely on master, but now this will print only once as no state was modified.

class Flow(LightningFlow):
    def run(self):
        logger.info("Hello World")

app = LightningApp(Flow())

Parts of Lightning-AI/lightning-app#938

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 7, 2022
@tchaton tchaton added this to the app:0.6 milestone Aug 7, 2022
@tchaton tchaton changed the title Serveless Change (app) Run the flow only if the state has updated Aug 7, 2022
@tchaton tchaton changed the title (app) Run the flow only if the state has updated (app) Run the flow only if the state has updated 1/2 Aug 7, 2022
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that we're getting to this, really important.

It checks out, I've mostly got a question around the scheduler test.

src/lightning_app/core/app.py Outdated Show resolved Hide resolved
tests/tests_app/core/test_lightning_flow.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the scheduler frequency. We should keep it at a second granularity (so 0.5 timeout is fine) and document it, and just patch it during testing to make tests faster.

src/lightning_app/utilities/scheduler.py Outdated Show resolved Hide resolved
tests/tests_app/core/test_lightning_app.py Show resolved Hide resolved
@tchaton tchaton requested a review from lantiga August 10, 2022 11:48
@mergify mergify bot added the ready PRs ready to be merged label Aug 10, 2022
@tchaton tchaton merged commit b8b8f03 into master Aug 10, 2022
@tchaton tchaton deleted the serverless_breaking_change branch August 10, 2022 12:56
jessecambon pushed a commit to jessecambon/lightning that referenced this pull request Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants