Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Start Lightning App on Cloud if Repo Begins With Name "Lightning" #14025

Merged
merged 5 commits into from
Aug 8, 2022

Conversation

rlizzo
Copy link
Contributor

@rlizzo rlizzo commented Aug 4, 2022

What does this PR do?

Ensure that if a repository starts with the name "lightning" that it can actually be packaged and run on the cloud. This was occurring due to not checking if the package is installed in editable mode or not. if it is not installed in editable mode, do not package the source :)

Fixes #13942
Fixes #13913

Note for Reviewers: I am having trouble figuring out how to test this. One option would be to completely mock out the _PACKAGE_ROOT variable, but this does not seem like a particularly useful test to actually ensure functionality? Looking for input here.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [ ] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

@rlizzo rlizzo self-assigned this Aug 4, 2022
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 4, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rlizzo rlizzo force-pushed the grid-9818-lightning-framework-development-project branch from 88ccab6 to cf72a29 Compare August 5, 2022 14:53
@rlizzo rlizzo marked this pull request as ready for review August 5, 2022 14:56
@rlizzo rlizzo force-pushed the grid-9818-lightning-framework-development-project branch from 262db9c to 4266b5d Compare August 5, 2022 14:58
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged and released asap

@tchaton @Borda

@mergify mergify bot added the ready PRs ready to be merged label Aug 8, 2022
@awaelchli awaelchli added the bug Something isn't working label Aug 8, 2022
@awaelchli awaelchli added this to the app:0.5.x milestone Aug 8, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 8, 2022 10:40
@awaelchli awaelchli merged commit b4ade23 into master Aug 8, 2022
@awaelchli awaelchli deleted the grid-9818-lightning-framework-development-project branch August 8, 2022 11:13
Borda pushed a commit that referenced this pull request Aug 9, 2022
lexierule pushed a commit that referenced this pull request Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package bug Something isn't working ready PRs ready to be merged
Projects
No open projects
Status: Done
5 participants