-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Start Lightning App on Cloud if Repo Begins With Name "Lightning" #14025
Merged
awaelchli
merged 5 commits into
master
from
grid-9818-lightning-framework-development-project
Aug 8, 2022
Merged
Fix: Start Lightning App on Cloud if Repo Begins With Name "Lightning" #14025
awaelchli
merged 5 commits into
master
from
grid-9818-lightning-framework-development-project
Aug 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e how to test at this moment
github-actions
bot
added
the
app (removed)
Generic label for Lightning App package
label
Aug 4, 2022
tchaton
approved these changes
Aug 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
rlizzo
force-pushed
the
grid-9818-lightning-framework-development-project
branch
from
August 5, 2022 14:53
88ccab6
to
cf72a29
Compare
rlizzo
force-pushed
the
grid-9818-lightning-framework-development-project
branch
from
August 5, 2022 14:58
262db9c
to
4266b5d
Compare
for more information, see https://pre-commit.ci
lantiga
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hhsecond
approved these changes
Aug 8, 2022
awaelchli
approved these changes
Aug 8, 2022
awaelchli
reviewed
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
bug
Something isn't working
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ensure that if a repository starts with the name "lightning" that it can actually be packaged and run on the cloud. This was occurring due to not checking if the package is installed in editable mode or not. if it is not installed in editable mode, do not package the source :)
Fixes #13942
Fixes #13913
Note for Reviewers:
I am having trouble figuring out how to test this. One option would be to completely mock out the_PACKAGE_ROOT
variable, but this does not seem like a particularly useful test to actually ensure functionality? Looking for input here.Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
[ ] Did you make sure to update the documentation with your changes? (if necessary)[ ] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
cc @Borda