-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(app) Introduce configure_api and Post, Get, Delete, Put HttpMethods #13945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tchaton can you add a valid use case for this feature (that you cannot accomplish with configure_route
) in the PR description please (perhaps we could port the same over to the doc as well)?
Hey @hhsecond, I am not entirely sure to understand your question. There isn't a The use case is to enable users to register their own external API so they can provide ways for their app to interact with the outside world. Similar to a controlplane. Within the LightningHPO App, I am using it to enable users to fetch structured information about the app. I believe long term this would enable us to create more complex app with a more clearly defined controlplane. Right now, I am starting to have a slightly different way to see the distributed state. I think the state should stay in the backend and acts to orchestrate the data plane, but the API should acts as the controlplane and enable modifying the state to start works or fetch data from a persistent database. Best, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, just a few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tiny comments
What does this PR do?
After chatting with @lantiga, we thought there is a need to enable users to expose their own API through the App Rest API.
This PR introduces
configure_api
hook to the LightningFlow and Post, Put, Delete and Get HttpMethods.TODOS: In another PR, rename the queues and unify API with commands.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda