Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(app) Introduce LightningTrainingComponent #13830

Merged
merged 52 commits into from
Jul 29, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 25, 2022

What does this PR do?

This PR introduces a LightningTrainingComponent which provides multi-node training in the cloud.

from lightning import LightningApp
from lightning.app.components.training import LightningTrainingComponent
from lightning_app.utilities.packaging.cloud_compute import CloudCompute

app = LightningApp(
    LightningTrainingComponent(
        "train.py",
        num_nodes=2,
        cloud_compute=CloudCompute("CPU"),
    ),
)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton changed the title Temporary Multi Node Component. Jul 25, 2022
@tchaton tchaton marked this pull request as ready for review July 25, 2022 18:45
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Jul 25, 2022
@tchaton tchaton changed the title Multi Node Component. (app) Introduce LightningTrainingComponent Jul 25, 2022
@tchaton tchaton marked this pull request as ready for review July 28, 2022 08:46
src/lightning_app/core/flow.py Outdated Show resolved Hide resolved
src/lightning_app/utilities/proxies.py Outdated Show resolved Hide resolved
src/lightning_app/utilities/state.py Outdated Show resolved Hide resolved
@tchaton tchaton merged commit aefb9ab into master Jul 29, 2022
@tchaton tchaton deleted the add_lightning_training_component_2 branch July 29, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants