-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add UI for install all #13732
Merged
Merged
add UI for install all #13732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
requested review from
williamFalcon,
tchaton,
SeanNaren,
carmocca,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
July 19, 2022 10:28
manskx
approved these changes
Jul 19, 2022
Borda
added
priority: 1
Medium priority task
and removed
priority: 0
High priority task
labels
Jul 19, 2022
rohitgr7
approved these changes
Jul 19, 2022
manskx
approved these changes
Jul 19, 2022
kaushikb11
approved these changes
Jul 20, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jul 25, 2022
tchaton
approved these changes
Jul 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Borda
added a commit
that referenced
this pull request
Jul 29, 2022
* add UI for install all (cherry picked from commit a58a406)
lexierule
pushed a commit
that referenced
this pull request
Aug 1, 2022
* add UI for install all (cherry picked from commit a58a406)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app (removed)
Generic label for Lightning App package
priority: 1
Medium priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when you install full lightning, also include UI
+ adding CI check that packages build with {app,pytorch,lightning} include only single package
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @tchaton @rohitgr7