Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UI for install all #13732

Merged
merged 8 commits into from
Jul 28, 2022
Merged

add UI for install all #13732

merged 8 commits into from
Jul 28, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 19, 2022

What does this PR do?

when you install full lightning, also include UI
+ adding CI check that packages build with {app,pytorch,lightning} include only single package

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7

@Borda Borda added priority: 1 Medium priority task and removed priority: 0 High priority task labels Jul 19, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 19, 2022
@Borda Borda requested a review from akihironitta as a code owner July 19, 2022 10:33
@Borda Borda added this to the future milestone Jul 19, 2022
@akihironitta akihironitta added the app (removed) Generic label for Lightning App package label Jul 19, 2022
@Borda Borda requested a review from manskx July 19, 2022 17:53
@Borda Borda modified the milestones: pl:future, app:0.5.x Jul 19, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 20, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 25, 2022
@Borda Borda modified the milestones: app:0.5.x, app:0.6 Jul 25, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda merged commit a58a406 into master Jul 28, 2022
@Borda Borda deleted the pkg/add-ui branch July 28, 2022 12:09
@Borda Borda modified the milestones: app:0.6, app:0.5.x Jul 28, 2022
Borda added a commit that referenced this pull request Jul 29, 2022
* add UI for install all

(cherry picked from commit a58a406)
lexierule pushed a commit that referenced this pull request Aug 1, 2022
* add UI for install all

(cherry picked from commit a58a406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (removed) Generic label for Lightning App package priority: 1 Medium priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants