-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run only CUDA tests on Azure GPU CI #13651
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit 25935fe.
how about test that is written such uses how about #13664? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it ! This is a great step.
I see the motivation for this PR and agree no need to run tests using only CPU on GPU machine but I think that for robustness we shall all push to use instance maximal potential... that is also why @kaushikb11 started #12482 and similar for TPU and IPU... |
#12482 does exactly what this PR does, but for HPUs. Collect automatically all HPU tests and run them exclusively.
This is what this PR does
This PR does not go against this idea. It just filters out the jobs that don't require CUDA |
true, so the way out would be to introduce a flag for tests to run everywhere? |
Depends on what we want. For example, we could have a |
I would do it vise-versa, by default, run all and if some short-run set env variable |
Good point: #13676 |
What does this PR do?
Run only the CUDA tests on Azure GPU CI. Just as we do for TPUs, IPUs, and HPUs CI jobs.
This should slash the runtime considerably.
This logically reduces the coverage as CPU-only code could fail if run on a GPU environment. But this tradeoff is currently worth it given our limitations in GPU testing.
Reduces the "Standard" tests step from GPU ci from ~24' to ~10'
Discussed internally.
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @carmocca @akihironitta @Borda