[App] Application logs in CLI

[adam-lightning]

What does this PR do?

This PR adds CLI command lightning show logs <app_name> [<components>] that prints logs

Does your PR introduce any breaking changes? If yes, please list them.

We've extended the run_app_in_cloud context manager to return app_name as well. This is to enable easier testing, but might also affect other existing tests from different repositories.

Before submitting

• Was this discussed/approved via a GitHub issue? (not for typos and docs)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes? (if necessary)
• Did you write any new necessary tests? (not for typos and docs)
• Did you verify new and existing tests pass locally with your changes?
• Did you list all the breaking changes introduced by this pull request?
• Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

• Is this pull request ready for review? (if not, please submit in draft mode)
• Check that all items from Before submitting are resolved
• Make sure the title is self-explanatory and the description concisely explains the PR
• Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

[williamFalcon]

is “show” the best command word here? @adam-lightning.
how will this generalize as the CLI evolves?

[adam-lightning]

@williamFalcon The idea is that show would be for showing / displaying / printing all information about given resource(s).
Something like just saying "Show me logs of X", "show me something ...", "show me my application" etc.

Tho, for the future, I'd distinguish the "show" from "list" as one first one answers the question about the object's contents / details, and the other lists the objects we might want to interact with.

Or You mean something else by the CLI evolution ?

[williamFalcon]

that makes sense. i'm just thinking about what else "show" will apply to other than logs

[manskx]

@adam-lightning We should add two things:

• An issue/ticket to create update the docs
• Update changelog

[adam-lightning]

@adam-lightning We should add two things:

• An issue/ticket to create update the docs
• Update changelog

@manskx

• Just create a ticket or also implement it before merging this PR ?
• I haven't found changelog in the existing files. Should I create one?

[manskx]

@adam-lightning We should add two things:

• An issue/ticket to create update the docs
• Update changelog

@manskx

• Just create a ticket or also implement it before merging this PR ?
• I haven't found changelog in the existing files. Should I create one?

Would be nice to update the docs in the same PR :))) up to you

changelog is here: https://github.com/Lightning-AI/lightning/blob/35ec79ad1f75790767a6857637c9bbe052e47b58/src/lightning_app/CHANGELOG.md

[tchaton]

LGTM once the comments are addressed.

[awaelchli]

I like "show". For a different product, we had a CLI redesign planned (now on ice) where "show" was supposed to show information about many different types resources. It also fits well for logs.

lightning show [what] [name or id]

[awaelchli]

This probably works well for some apps, and is a good start. I just want to point out that an app doesn't need to have a constant amount of "components". These could come and go during runtime of the app. So if you "follow" the logs, that's probably useful to know.

[tchaton]

Yes, this is definitely a skateboard version and needs to be improved upon.