-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --app_args support from the CLI #13625
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaton
changed the title
Add AppArgs support from the CLI
Add --app_args support from the CLI
Jul 12, 2022
otaj
reviewed
Jul 12, 2022
github-actions
bot
removed
the
app (removed)
Generic label for Lightning App package
label
Jul 12, 2022
otaj
reviewed
Jul 12, 2022
otaj
reviewed
Jul 12, 2022
tchaton
commented
Jul 12, 2022
krshrimali
reviewed
Jul 12, 2022
otaj
reviewed
Jul 12, 2022
Co-authored-by: Kushashwa Ravi Shrimali <[email protected]>
otaj
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now we're golden :)
krshrimali
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 Thanks!
manskx
approved these changes
Jul 12, 2022
rohitgr7
approved these changes
Jul 13, 2022
tchaton
requested review from
williamFalcon,
Borda,
SeanNaren,
carmocca,
justusschock and
kaushikb11
as code owners
July 13, 2022 10:49
github-actions
bot
removed
the
app (removed)
Generic label for Lightning App package
label
Jul 13, 2022
otaj
reviewed
Jul 13, 2022
mergify
bot
added
ready
PRs ready to be merged
and removed
has conflicts
ready
PRs ready to be merged
labels
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables passing arguments to an app.py relying on Argparse.
It patches Argparse to prevent parsing verification through the parse_known_args method.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda