Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --app_args support from the CLI #13625

Merged
merged 18 commits into from
Jul 15, 2022
Merged

Add --app_args support from the CLI #13625

merged 18 commits into from
Jul 15, 2022

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jul 12, 2022

What does this PR do?

This PR enables passing arguments to an app.py relying on Argparse.

It patches Argparse to prevent parsing verification through the parse_known_args method.

lightning run app examples/app_argparse/app.py --app_args  --use_gpu --without-server

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton changed the title Add AppArgs support from the CLI Add --app_args support from the CLI Jul 12, 2022
@tchaton tchaton marked this pull request as ready for review July 12, 2022 13:12
@tchaton tchaton added app (removed) Generic label for Lightning App package app:cli labels Jul 12, 2022
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Jul 12, 2022
@tchaton tchaton requested a review from otaj July 12, 2022 14:15
src/lightning_app/cli/lightning_cli.py Show resolved Hide resolved
src/lightning_app/utilities/load_app.py Outdated Show resolved Hide resolved
src/lightning_app/utilities/load_app.py Outdated Show resolved Hide resolved
src/lightning_app/utilities/load_app.py Outdated Show resolved Hide resolved
src/lightning_app/utilities/load_app.py Show resolved Hide resolved
@tchaton tchaton requested a review from otaj July 12, 2022 15:46
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we're golden :)

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks!

src/lightning_app/utilities/load_app.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jul 12, 2022
@akihironitta akihironitta added the app (removed) Generic label for Lightning App package label Jul 13, 2022
src/lightning_app/utilities/load_app.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Jul 13, 2022
@tchaton tchaton enabled auto-merge (squash) July 15, 2022 14:12
@tchaton tchaton added this to the app:0.6 milestone Jul 15, 2022
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 15, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 15, 2022
@tchaton tchaton disabled auto-merge July 15, 2022 15:29
@tchaton tchaton merged commit 2a873da into master Jul 15, 2022
@tchaton tchaton deleted the add_app_args branch July 15, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants