Parity test #1284
Merged
Parity test #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-03-30 20:36:52 UTC |
Codecov Report
@@ Coverage Diff @@
## master #1284 +/- ##
======================================
Coverage 92% 92%
======================================
Files 62 62
Lines 3186 3186
======================================
+ Hits 2918 2922 +4
+ Misses 268 264 -4 |
Borda
requested changes
Mar 29, 2020
There was a problem hiding this comment.
seeing the times in https://colab.research.google.com/drive/1qvQdkiTfCeHot6Db9OI1acXqqn3qZdYO
[91.86524063200068,
85.56170413900054,
84.75839297699986,
84.57833823100009,
83.36381064600027,
83.92036224000003,
82.86866674199973,
84.17941058999986,
83.78484545599986,
84.37455196700012]
and
[66.38168524299999,
65.64241816699996,
66.31059756800005,
66.223956154,
65.61999890100014,
66.78608379100024,
66.0117561119996,
66.16935832099989,
65.6803158140001,
65.55979780100006]
is I udentads correctly the the unit are seconds it adds 30min to each buld which my icrease single CI test from 15min as it is now to more than 1h depending on concurency
Borda
approved these changes
Mar 29, 2020
|
@williamFalcon still it takes about 5min extra... |
alexeykarnachev
pushed a commit
to alexeykarnachev/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* adding test * adding test * added base parity model * added base parity model * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * added parity test * move parity to benchmark * formatting * fixed gradient acc sched * move parity to benchmark * formatting * fixed gradient acc sched * skip for CPU * call last Co-authored-by: J. Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a parity test for pytorch vanilla and lightning