-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename DDPPlugin
to DDPStrategy
#11142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
awaelchli,
Borda,
carmocca,
edenlightning,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 17, 2021 22:44
four4fish
changed the title
Raname DDPPlugin to DDPStrategy
Raname Dec 17, 2021
DDPPlugin
to DDPStrategy
carmocca
approved these changes
Dec 17, 2021
ananthsub
approved these changes
Dec 18, 2021
awaelchli
changed the title
Raname
Rename Dec 18, 2021
DDPPlugin
to DDPStrategy
DDPPlugin
to DDPStrategy
awaelchli
approved these changes
Dec 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found more occurrences and fixed them. This should go after #11120
justusschock
approved these changes
Dec 20, 2021
ananthsub
approved these changes
Dec 20, 2021
four4fish
force-pushed
the
rename/ddp
branch
from
December 20, 2021 21:59
f3cb6fc
to
f9334e3
Compare
akihironitta
approved these changes
Dec 21, 2021
tchaton
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Includes a breaking change
ready
PRs ready to be merged
refactor
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
part of #10549
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃