-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Trainer.training_type_plugin in favor of trainer.strategy #11141
Deprecate Trainer.training_type_plugin in favor of trainer.strategy #11141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11141 +/- ##
=======================================
Coverage 88% 88%
=======================================
Files 177 177
Lines 16760 16764 +4
=======================================
+ Hits 14778 14782 +4
Misses 1982 1982 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Some commands that you might find useful for follow-ups
$ grep -iIrn "ttp" pytorch_lightning tests | grep -vi "http"
$ grep -iIrn "training_type" pytorch_lightning tests
@carmocca Good call! Updated ttp and training_type words. The training_type pass in import will be updated when we change the file name |
aaf274b
to
c27d56c
Compare
a0264aa
to
6063f70
Compare
eeb61bf
to
261ebd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Nice progress.
ca687f5
to
d31a27e
Compare
Head branch was pushed to by a user without write access
for more information, see https://pre-commit.ci
Head branch was pushed to by a user without write access
What does this PR do?
follow up for #11120 will rebase after it get merged
part of the clean up work for #10416
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃