Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Trainer.training_type_plugin in favor of trainer.strategy #11141

Merged
merged 5 commits into from
Dec 22, 2021

Conversation

four4fish
Copy link
Contributor

@four4fish four4fish commented Dec 17, 2021

What does this PR do?

follow up for #11120 will rebase after it get merged

part of the clean up work for #10416

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@four4fish four4fish marked this pull request as draft December 17, 2021 21:22
@four4fish four4fish changed the title Update/strategy/reference Replace training_type_plugin reference and with strategy Dec 17, 2021
@four4fish four4fish added this to the 1.6 milestone Dec 17, 2021
@four4fish four4fish marked this pull request as ready for review December 17, 2021 21:48
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #11141 (3189996) into master (17ad1a4) will increase coverage by 0%.
The diff coverage is 87%.

@@           Coverage Diff           @@
##           master   #11141   +/-   ##
=======================================
  Coverage      88%      88%           
=======================================
  Files         177      177           
  Lines       16760    16764    +4     
=======================================
+ Hits        14778    14782    +4     
  Misses       1982     1982           

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Some commands that you might find useful for follow-ups

$ grep -iIrn "ttp" pytorch_lightning tests | grep -vi "http"
$ grep -iIrn "training_type" pytorch_lightning tests

@four4fish
Copy link
Contributor Author

training_type

@carmocca Good call! Updated ttp and training_type words. The training_type pass in import will be updated when we change the file name

@four4fish four4fish force-pushed the update/strategy/reference branch from aaf274b to c27d56c Compare December 18, 2021 01:38
@four4fish four4fish changed the title Replace training_type_plugin reference and with strategy Deprecate Trainer.training_type_plugin in favor of trainer.strategy Dec 18, 2021
@four4fish four4fish requested a review from awaelchli December 18, 2021 01:56
@four4fish four4fish force-pushed the update/strategy/reference branch from a0264aa to 6063f70 Compare December 20, 2021 21:28
@mergify mergify bot removed the has conflicts label Dec 20, 2021
@four4fish four4fish force-pushed the update/strategy/reference branch from eeb61bf to 261ebd0 Compare December 20, 2021 21:35
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Nice progress.

@four4fish four4fish force-pushed the update/strategy/reference branch from ca687f5 to d31a27e Compare December 21, 2021 23:36
@mergify mergify bot removed the has conflicts label Dec 21, 2021
@ananthsub ananthsub enabled auto-merge (squash) December 21, 2021 23:54
auto-merge was automatically disabled December 22, 2021 00:00

Head branch was pushed to by a user without write access

@mergify mergify bot removed the has conflicts label Dec 22, 2021
@ananthsub ananthsub enabled auto-merge (squash) December 22, 2021 00:04
auto-merge was automatically disabled December 22, 2021 00:29

Head branch was pushed to by a user without write access

@mergify mergify bot removed the has conflicts label Dec 22, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 22, 2021 01:11
@awaelchli awaelchli merged commit cf5ef32 into Lightning-AI:master Dec 22, 2021
@Borda Borda mentioned this pull request Mar 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor strategy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants