Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove should_rank_save_checkpoint property from TTP #11070

Merged
merged 10 commits into from
Dec 21, 2021
Merged

Remove should_rank_save_checkpoint property from TTP #11070

merged 10 commits into from
Dec 21, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 15, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Finishes #9074

Does your PR introduce any breaking changes? If yes, please list them.

TTP API (experimental): removes the property

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @kaushikb11 @justusschock @awaelchli @akihironitta @ananthsub

@carmocca carmocca added this to the 1.6 milestone Dec 15, 2021
@carmocca carmocca self-assigned this Dec 15, 2021
@carmocca carmocca requested a review from kaushikb11 December 15, 2021 04:07
@carmocca carmocca marked this pull request as ready for review December 15, 2021 05:00
@awaelchli awaelchli added the accelerator: tpu Tensor Processing Unit label Dec 15, 2021
@jjenniferdai
Copy link
Contributor

@carmocca @ananthsub see #11068 (comment) re: Trainer property removal v.s. deprecation?

@carmocca
Copy link
Contributor Author

@jjenniferdai We don't need to keep BC for the property in the TTP. Since the property in the Trainer is read-only, we can copy its current implementation into it.

Whichever PR lands later should be updated.

tchaton
tchaton approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Dec 17, 2021
@carmocca carmocca mentioned this pull request Dec 17, 2021
Closed
@carmocca carmocca enabled auto-merge (squash) December 17, 2021 16:57
@mergify mergify bot removed the has conflicts label Dec 20, 2021
@mergify mergify bot removed the has conflicts label Dec 20, 2021
@carmocca carmocca merged commit f696326 into master Dec 21, 2021
@carmocca carmocca deleted the remove/should_rank_save_ckpt branch December 21, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaton tchaton tchaton approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@jjenniferdai jjenniferdai Awaiting requested review from jjenniferdai

@four4fish four4fish Awaiting requested review from four4fish

@ananthsub ananthsub Awaiting requested review from ananthsub

Assignees

@carmocca carmocca

Labels
accelerator: tpu Tensor Processing Unit plugin ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@carmocca @jjenniferdai @ananthsub @awaelchli @Borda @tchaton @four4fish