Skepticleo trainer argparser #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r from default args
…rch-lightning into trainerArgparser # Conflicts: # pytorch_lightning/trainer/trainer.py
…rchLightning/pytorch-lightning into skepticleo-trainerArgparser
Borda
reviewed
Mar 3, 2020
Borda
reviewed
Mar 3, 2020
pytorch_lightning/trainer/trainer.py
Outdated
| return parser | ||
|
|
||
| @classmethod | ||
| def from_argparse_args(cls, args) -> Trainer: |
There was a problem hiding this comment.
Suggested change
| def from_argparse_args(cls, args) -> Trainer: | |
| def from_argparse_args(cls, args: Namespace) -> Trainer: |
Borda
reviewed
Mar 3, 2020
Borda
reviewed
Mar 3, 2020
Co-Authored-By: Jirka Borovec <[email protected]>
Co-Authored-By: Jirka Borovec <[email protected]>
Co-Authored-By: Jirka Borovec <[email protected]>
|
@Borda how do we change the author to the original one? |
5 tasks
awaelchli
reviewed
Mar 3, 2020
|
|
||
| @classmethod | ||
| def from_argparse_args(cls, args): | ||
|
|
There was a problem hiding this comment.
shouldn't there be documentation where the blank line is? did it get lost?
Closed
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* Added default parser for trainer and class method to construct trainer from default args * Removed print statement * Added test for constructing Trainer from command line args * Removed extra line * Removed redundant imports, removed whitespace from empty lines * Fixed typo * Updated default parser creation to get class attributes automatically * Updated default parser creation to get class attributes automatically * Added method to get default args for trainer * Trimmed trainer get default args method * Updated from argparse method to not return trainer with static arguments * Update trainer get default args to classmethod * adjustment * fix * Fixed variable name * Update trainer.py * Update test_trainer.py * Update trainer.py * Update tests/trainer/test_trainer.py Co-Authored-By: Jirka Borovec <[email protected]> * Update trainer.py * Update test_trainer.py * Update trainer.py * Update test_trainer.py * Update tests/trainer/test_trainer.py Co-Authored-By: Jirka Borovec <[email protected]> * Update pytorch_lightning/trainer/trainer.py Co-Authored-By: Jirka Borovec <[email protected]> * Update trainer.py * Update test_trainer.py Co-authored-by: Mudit Tanwani <[email protected]> Co-authored-by: Jirka Borovec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Duplicate to #952
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃