Merge 709d4bf into 4f391bc

CHANGELOG.md

@@ -20,6 +20,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
 
 - Added arg to `self.log` that enables users to give custom names when dealing with multiple dataloaders ([#6274](https://github.com/PyTorchLightning/pytorch-lightning/pull/6274))
 
+- Added teardown method to BaseProfiler to enable subclasses define post-profiling steps outside of __del__ method.
 
 ### Changed
 

pytorch_lightning/profiler/profilers.py

@@ -55,6 +55,10 @@ def start(self, action_name: str) -> None:
     def stop(self, action_name: str) -> None:
         """Defines how to record the duration once an action is complete."""
 
+    @abstractmethod
+    def teardown(self) -> None:
+        """Execute arbitrary post-profiling tear-down steps as defined by subclass."""
+
     @contextmanager
     def profile(self, action_name: str) -> None:
         """
@@ -114,6 +118,9 @@ def start(self, action_name: str) -> None:
     def stop(self, action_name: str) -> None:
         pass
 
+    def teardown(self) -> None:
+        pass
+
     def summary(self) -> str:
         return ""
 
@@ -214,11 +221,14 @@ def describe(self):
         if self.output_file:
             self.output_file.flush()
 
-    def __del__(self):
+    def teardown(self) -> None:
         """Close profiler's stream."""
         if self.output_file:
             self.output_file.close()
 
+    def __del__(self):
+        self.teardown()
+
 
 class AdvancedProfiler(BaseProfiler):
     """
@@ -286,7 +296,10 @@ def describe(self):
         if self.output_file:
             self.output_file.flush()
 
-    def __del__(self):
+    def teardown(self) -> None:
         """Close profiler's stream."""
         if self.output_file:
             self.output_file.close()
+
+    def __del__(self):
+        self.teardown()

pytorch_lightning/profiler/pytorch.py

@@ -297,7 +297,10 @@ def describe(self):
         if self.output_file:
             self.output_file.flush()
 
-    def __del__(self):
+    def teardown(self) -> None:
         """Close profiler's stream."""
         if self.output_file:
             self.output_file.close()
+
+    def __del__(self):
+        self.teardown()