Skip to content

Commit

Permalink
CI: Upload video artifacts from e2e tests (#14467)
Browse files Browse the repository at this point in the history
* CI: try upload e2e Artifacts
* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <[email protected]>
  • Loading branch information
Borda and akihironitta authored Nov 1, 2022
1 parent 93a6cff commit 7ee0994
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
11 changes: 8 additions & 3 deletions .azure/app-cloud-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ variables:
value: $(Pipeline.Workspace)/.pip
- name: local_id
value: $(Build.BuildId)
- name: video_artifact_dir
value: ./videos

jobs:
- job: App_cloud_e2e_testing
Expand Down Expand Up @@ -86,6 +88,7 @@ jobs:

- bash: |
whoami
mkdir -p $(video_artifact_dir)
printf "local id: $(local_id)\n"
python --version
pip --version
Expand Down Expand Up @@ -150,7 +153,7 @@ jobs:
HEADLESS: '1'
PACKAGE_LIGHTNING: '1'
CLOUD: '1'
VIDEO_LOCATION: '$(Build.ArtifactStagingDirectory)/videos'
VIDEO_LOCATION: $(video_artifact_dir)
PR_NUMBER: $(local_id)
TEST_APP_NAME: $(name)
HAR_LOCATION: './artifacts/hars'
Expand All @@ -164,10 +167,12 @@ jobs:
LIGHTNING_DEBUG: '1'
displayName: 'Run the tests'
- publish: '$(Build.ArtifactStagingDirectory)/videos'
- task: PublishPipelineArtifact@1
condition: failed()
inputs:
path: $(video_artifact_dir)
artifactName: $(name)
displayName: 'Publish videos'
artifact: $(name)

- bash: |
time python -c "from lightning.app import testing; testing.delete_cloud_lightning_apps()"
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci-schema.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,8 @@ on:

jobs:
check:
uses: Lightning-AI/devtools/.github/workflows/[email protected]
uses: Lightning-AI/utilities/.github/workflows/[email protected]
with:
# skip azure due to the wrong schema file by MSFT
# https://github.com/Lightning-AI/lightning-flash/pull/1455#issuecomment-1244793607
azure-dir: ''

0 comments on commit 7ee0994

Please sign in to comment.