Skip to content

Commit

Permalink
Removed deprecated property is_using_torchelastic from AcceleratorCon…
Browse files Browse the repository at this point in the history
…nector (#9729)
  • Loading branch information
daniellepintz authored Sep 28, 2021
1 parent 131176b commit 43896a7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 14 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Removed deprecated properties `DeepSpeedPlugin.cpu_offload*` in favor of `offload_optimizer`, `offload_parameters` and `pin_memory` ([#9244](https://github.com/PyTorchLightning/pytorch-lightning/pull/9244))


- Removed deprecated property `AcceleratorConnector.is_using_torchelastic` in favor of `TorchElasticEnvironment.is_using_torchelastic()` ([#9729](https://github.com/PyTorchLightning/pytorch-lightning/pull/9729))


- Removed `pytorch_lightning.utilities.debugging.InternalDebugger` ([#9680](https://github.com/PyTorchLightning/pytorch-lightning/pull/9680))


Expand Down
14 changes: 0 additions & 14 deletions pytorch_lightning/trainer/connectors/accelerator_connector.py
Original file line number Diff line number Diff line change
Expand Up @@ -534,20 +534,6 @@ def root_gpu(self) -> Optional[int]:
def is_training_type_in_plugins(self) -> bool:
return any(isinstance(plug, str) and plug in TrainingTypePluginsRegistry for plug in self.plugins)

@property
def is_using_torchelastic(self) -> bool:
"""
.. deprecated:: v1.3
Will be removed in v1.5.0.
Returns:
``True`` if the current process was launched using the torchelastic command.
"""
rank_zero_deprecation(
"The property `AcceleratorConnector.is_using_torchelastic` was deprecated in v1.3"
" and will be removed in 1.5. Use `TorchElasticEnvironment.is_using_torchelastic()` instead."
)
return TorchElasticEnvironment.is_using_torchelastic()

def select_precision_plugin(self) -> PrecisionPlugin:
# set precision type
self.amp_type = AMPType.from_str(self.amp_type)
Expand Down

0 comments on commit 43896a7

Please sign in to comment.