Conversation
ysjprojects
requested review from
Borda,
lantiga,
t-vi and
williamFalcon
as code owners
for more information, see https://pre-commit.ci
Collaborator
|
seems you may need to bump the dependency for |
KaelanDt
reviewed
May 16, 2025
Contributor
KaelanDt
left a comment
KaelanDt
left a comment
There was a problem hiding this comment.
Very nice! Could you also add other versions of the dense model (not just 8B)? Should just be adding the configs in config.py and modifying the readme
Collaborator
Author
yes! will do |
Collaborator
Author
Borda
approved these changes
May 24, 2025
KaelanDt
approved these changes
May 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links:
https://arxiv.org/abs/2505.09388
https://qwenlm.github.io/blog/qwen3/
#2031
Added Qwen3 dense models (Currently Qwen3-8B).
NOTE: transformers>=4.51.0 is required (Awaiting #2029)