Add precision arg for pretraining #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasbt
commented
Apr 24, 2024
Merged
carmocca
approved these changes
Apr 25, 2024
Co-authored-by: Carlos Mocholí <[email protected]>
|
In #882 I set it to mixed because of convergence stability. It would be great if we could leave the TinyLlama defaults untouched to be consistent with the original repro settings. For pretraining, I see mixed as the better default, even for the toy examples. Can we keep that please? |
|
Arg yes, typing "bf16-true" must have been a weird muscle memory reflex. I didn't intentionally mean to change this. Thanks for the note. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows selecting the precision for pretraining.