Terminate threads to avoid test interactions - #244
Merged
Merged
Conversation
awaelchli
marked this pull request as ready for review
July 19, 2024 18:07
tchaton
approved these changes
Jul 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a fixture that runs on each test, monitoring whether the test left threads behind. This logic is adapted from PyTorch Lightning. Avoids test interactions from threading, and will raise error if new tests added in the future will leave threads behind.
This doesn't solve the issues with optimize() I've seen in #237, but it should still be a helpful as a sanity check.