Skip to content

Conversation

@Ever2after
Copy link
Contributor

Checkpoint name in generate_lora.py 'adapter_checkpoint' seems better to be changed to 'lora_checkpoint'.

@Ever2after Ever2after closed this May 8, 2023
@Ever2after Ever2after deleted the ever2after/fix branch May 8, 2023 18:26
@Ever2after Ever2after restored the ever2after/fix branch May 8, 2023 18:29
@awaelchli
Copy link
Contributor

I think this is a good change. Let's do it?

@Ever2after Ever2after reopened this May 8, 2023
Copy link
Collaborator

@lantiga lantiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Thank you @Ever2after

@lantiga lantiga merged commit 5d6472e into Lightning-AI:main May 8, 2023
rasbt pushed a commit to rasbt/lit-llama that referenced this pull request May 8, 2023
rasbt pushed a commit to rasbt/lit-llama that referenced this pull request May 8, 2023
rasbt pushed a commit to rasbt/lit-llama that referenced this pull request May 8, 2023
timothylimyl referenced this pull request in timothylimyl/lit-llama-qa May 21, 2023
timothylimyl referenced this pull request in timothylimyl/lit-llama-qa May 21, 2023
timothylimyl referenced this pull request in timothylimyl/lit-llama-qa May 21, 2023
timothylimyl referenced this pull request in timothylimyl/lit-llama-qa May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants