Makes Alert SSR compatible #66

LiferayCloud · Feb 16, 2018 · b265027 · b265027
1 parent f2c5fff
commit b265027
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/packages/marble-alert/src/Alert.js b/packages/marble-alert/src/Alert.js
@@ -1,4 +1,4 @@
-import {core} from 'metal';
+import {core, isServerSide} from 'metal';
 import dom from 'metal-dom';
 import Anim from 'metal-anim';
 import Component from 'metal-component';
@@ -22,6 +22,10 @@ class Alert extends Component {
    * @inheritDoc
    */
   detached() {
+    if (isServerSide()) {
+      return;
+    }
+
     super.detached();
     this.eventHandler_.removeAllListeners();
     clearTimeout(this.delay_);
@@ -86,6 +90,10 @@ class Alert extends Component {
    * @param {boolean} dismissible
    */
   syncDismissible(dismissible) {
+    if (isServerSide()) {
+      return;
+    }
+
     if (dismissible) {
       this.eventHandler_.add(
         dom.on(document, 'click', this.handleDocClick_.bind(this))
@@ -113,6 +121,10 @@ class Alert extends Component {
    * @param {boolean} visible
    */
   syncVisible(visible, prevVisible) {
+    if (isServerSide()) {
+      return;
+    }
+
     let shouldAsync = false;
     if (!visible) {
       dom.once(this.element, 'animationend', this.hideCompletely_.bind(this));

diff --git a/packages/marble-alert/test/Alert.node.js b/packages/marble-alert/test/Alert.node.js
@@ -0,0 +1,13 @@
+/**
+ * @jest-environment node
+ */
+
+import Component from 'metal-component';
+import Alert from '../src/Alert';
+
+describe('Alert.node', () => {
+  it('should not fail on the server side', () => {
+    const alert = Component.renderToString(Alert);
+    expect(alert).not.toBeNull();
+  });
+});