Makes Dropdown SSR compatible #66

LiferayCloud · Feb 20, 2018 · 78a1c6c · 78a1c6c
1 parent 5887712
commit 78a1c6c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/marble-dropdown/src/Dropdown.js b/packages/marble-dropdown/src/Dropdown.js
@@ -1,4 +1,4 @@
-import {core, object} from 'metal';
+import {core, object, isServerSide} from 'metal';
 import dom from 'metal-dom';
 import {Align} from 'metal-position';
 import Component from 'metal-component';
@@ -16,6 +16,11 @@ class Dropdown extends Component {
    */
   attached() {
     super.attached();
+
+    if (isServerSide()) {
+      return;
+    }
+
     this.eventHandler_.add(
       dom.on(document, 'click', this.handleDocClick_.bind(this))
     );

diff --git a/packages/marble-dropdown/test/Dropdown.node.js b/packages/marble-dropdown/test/Dropdown.node.js
@@ -0,0 +1,13 @@
+/**
+ * @jest-environment node
+ */
+
+import Component from 'metal-component';
+import Dropdown from '../src/Dropdown';
+
+describe('Dropdown.node', () => {
+  it('should not fail on the server side', () => {
+    const dropdown = Component.renderToString(Dropdown);
+    expect(dropdown).not.toBeNull();
+  });
+});