Makes CheckboxGroup SSR compatible #66

LiferayCloud · Feb 17, 2018 · 518b757 · 518b757
1 parent 72eb2ab
commit 518b757
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 14 deletions.
diff --git a/packages/marble-checkbox-group/src/CheckboxGroup.js b/packages/marble-checkbox-group/src/CheckboxGroup.js
@@ -27,14 +27,14 @@ CheckboxGroup.STATE = {
       label: Config.string(),
       value: Config.string(),
     })
-  ).required(),
+  ),
 
   /**
    * The name param used on each radio
    * @type {?String}
    * @default undefined
    */
-  name: Config.string().required(),
+  name: Config.string(),
 
   /**
    * The style of the radio group

diff --git a/packages/marble-checkbox-group/src/CheckboxGroup.soy b/packages/marble-checkbox-group/src/CheckboxGroup.soy
@@ -4,22 +4,24 @@
  * This renders the component's whole content.
  */
 {template .render}
-  {@param items: list<?>}
+  {@param? items: list<?>}
   {@param? name: string}
   {@param? style: string}
 
   <div class="{$style}">
-    {foreach $item in $items}
-      {let $checkedAttr kind="attributes"}
-        {if $item.checked}
-          checked="checked"
-        {/if}
-      {/let}
+    {if $items}
+      {foreach $item in $items}
+        {let $checkedAttr kind="attributes"}
+          {if $item.checked}
+            checked="checked"
+          {/if}
+        {/let}
 
-      <div class="checkbox">
-        <input id="{$item.id}" name="{$name}" value="{$item.value}" type="checkbox" {$checkedAttr}>
-        <label for="{$item.id}">{$item.label}</label>
-      </div>
-    {/foreach}
+        <div class="checkbox">
+          <input id="{$item.id}" name="{$name}" value="{$item.value}" type="checkbox" {$checkedAttr}>
+          <label for="{$item.id}">{$item.label}</label>
+        </div>
+      {/foreach}
+    {/if}
   </div>
 {/template}
diff --git a/packages/marble-checkbox-group/test/CheckboxGroup.node.js b/packages/marble-checkbox-group/test/CheckboxGroup.node.js
@@ -0,0 +1,13 @@
+/**
+ * @jest-environment node
+ */
+
+import Component from 'metal-component';
+import CheckboxGroup from '../src/CheckboxGroup';
+
+describe('CheckboxGroup.node', () => {
+  it('should not fail on the server side', () => {
+    const checkboxGroup = Component.renderToString(CheckboxGroup);
+    expect(checkboxGroup).not.toBeNull();
+  });
+});