linux: enable silead touchscreen driver modules for generic

[stpf99]

Hi this is draft for including silead driver and firmware for touchscreen tablets , for review and possible adoption, fetching from fw repo not tested , should be in Libreelec main repo tree cloned, and corresponding changes in package.mk should be adjusted...

[chewitt]

@stpf99 no problem to add support for the driver, but some changes needed:

• Please use =m not =y in the kernel defconfig
• Send the specific firmware for your device to https://github.com/LibreELEC/misc-firmware
• Update packages/firmware/misc-firmware/package.mk once the firmware has been merged
• Drop the separate gsl-firmware firmware package (no longer required)
• Rebase the PR so all changes are in a single commit
• Use package: description of change for commit message, e.g. linux: add silead touchscreen driver to generic

If there is future demand for lots more firmwares we can switch to using a gsl-firmware package, but until that happens we should avoid bloating the image by adding lots of firmwares that won't be used. NB: If we did use a package we would use the original upstream repo and not a fork that has no differences (release tags aren't required for downloading, we use the latest githash for PKG_VERSION.

[stpf99]

Hi. fw file for only my device is in LibreELEC/misc-firmware#9 ,i contributed this firmware and config to linux 6.6-rc , first to fw gsl repository and next to mailinglist and systemd quirks for rotation

[chewitt]

Please squash the [five] commits to a single commit and rename the single commit (not the pull-request) to linux: add silead touchscreen driver to generic

[chewitt]

NB: I don't see the firmware in the upstream linux-firmware repo: https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/ - can you please provide a link to the mailing list discussion?

[stpf99]

by now sorry but i cannot push to github by cmdline
fw contributed to gls-onitake and later only proper code changes to linux, and systemd for rotation
Kaz205/linux@34c271e and later to 6.5-stable was backported
systemd/systemd#29268

[stpf99]

libreelec can overlay firmware from /storage/.config/firmware/silead directory for this fw, so only including modules should be enough and some information on howto site for users or on forum with tablet devices which uses silead

[stpf99]

i prepared test img for this modules, silead.ko i have in image but touchscreen_dmi.ko not , i have question about https://www.kernelconfig.io/config_touchscreen_dmi , should all Depends and Selects must be listed in linux.x86_64.conf , and depends and selects for each one from any above parents must be listed ??? and this should be in proper places ? and i think manually editing config is probably not proper way ?

[stpf99]

i prepared new linux.x86_64.conf by "make menuconfig"

[chewitt]

drop this change

[chewitt]

drop this change

[chewitt]

drop this change

[chewitt]

I pushed changes to your repo with the commits squashed and renamed. I'm not sure why this closed the PR, but it may have something to do with you working in the master branch not a topic branch.

[stpf99]

some errors occured, don't know where is problem ... systemd/systemd#29268 "vddio" have something with systemd to do ?
LibreELEC-2:~ # dmesg |grep silead
[ 6.977512] silead_ts i2c-MSSL1680:00: supply vddio not found, using dummy regulator
[ 6.978283] silead_ts i2c-MSSL1680:00: supply avdd not found, using dummy regulator
[ 6.978633] silead_ts i2c-MSSL1680:00: Silead chip ID: 0x80360000
[ 13.025551] silead_ts i2c-MSSL1680:00: Initialization error, status: 0x0
[ 252.727557] silead_ts i2c-MSSL1680:00: supply vddio not found, using dummy regulator
[ 252.727856] silead_ts i2c-MSSL1680:00: supply avdd not found, using dummy regulator
[ 252.729841] silead_ts i2c-MSSL1680:00: Silead chip ID: 0x80360000
[ 260.257882] silead_ts i2c-MSSL1680:00: Initialization error, status: 0x0

[stpf99]

i have bow modules enablement in topic branch and PR is on #8483