Use ppxlib version 0.37 at least #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 30, 2025
|
Thanks @hhugo! I believe ppxlib 0.37.0 will be released shortly. As soon as that happens, we can update the lower bound here and then merge. |
|
ppxlib 0.37 has been released. @hhugo: do you mind updating the version constraint here and then we can merge? Thanks much! |
Update ocaml lower bound
Updated to ppxlib 0.37 |
hhugo
changed the title
|
Merged, thanks! I will try to get a release out soon. |
https://github.com/LexiFi/gen_js_api/releases/tag/v1.1.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ocaml/opam-repository#28160
One issue is that ppxlib 0.36 is currently broken an drops pvb_constraint on the floor when printing the AST.
So maybe we should bump the constraint to use the unreleased 0.36.1 version.
cc @NathanReb
EDIT: we now use ppxlib 0.37